Re: cvs: php-src /ext/mbstring mbstring.c mbstring.h /main rfc1867.c
| From: | Rui Hirokawa | Date: | Sun, 26 Oct 2003 00:42:54 +0000 |
| Subject: | Re: cvs: php-src /ext/mbstring mbstring.c mbstring.h /main rfc1867.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-24262@lists.php.net to get a copy of this message | ||
I think it is a kind of bug fix because,
1. name field of multipart/form was not converted into internal encoding.
This behavior is different from the usual GPC conversion performed by
mbstr_treat_data() and it might makes confusion for the users.
2. auto-detection might be fail because auto-detection was performed per
variables. It should be performed using the whole form data as in
mbstr_treat_data().
3. form field was converted into internal encoding even if
mbstring.http_input is set to 'pass'.
4.auto detection was performed even if mbstring.http_input is set to
'pass' or any valid encoding .
And the license fix is an another patch as Rasmus said.
Rui
On Sat, 25 Oct 2003 18:36:41 -0400
Ilia Alshanetsky <ilia@prohost.org> wrote:
> On October 25, 2003 06:22 pm, Rasmus Lerdorf wrote:
> > And continue breaking licenses knowingly?
>
> That patch does not fix licensing issues, it merely adds a feature, the
> license fix is not there...
>
> Patch log:
> name/value in multipart/form-date will be converted into internal encoding
> when mbstring.encoding_translation is On.
>
> Ilia
--
Rui Hirokawa <rui_hirokawa@ybb.ne.jp>