Re: cvs: php-src /ext/mbstring mbstring.c mbstring.h/main rfc1867.c

Ilia Alshanetsky <ilia@prohost.org> wrote: > On October 25, 2003 07:14 pm, Rasmus Lerdorf wrote: > > Ah, thought it was the other patch. However, I wouldn't call the above a > > new feature. That one is a bug fix as it was an oversight to not also > > convert form fields in multipart posts. > > Well, it is a mix of a feature & a bug fix. The bug if we decide to call it > such is by no means critical and 2 days before the release time is not a time > to make any non critical changes simply because there is no time to test I kind of agree with Ilia here. It'd be a bad idea to have GPC-related patch during the RC period, although the modified parts are all companied with #ifdef's as far as I'm concerned. > them. rfc1867.c is very sensitive code which previously had a number of > security faults at least 1 directly caused by mbstring related changes. It is > my opinion such changes have no place this late in the release cycle. Just want to make it clear, the past problem you mentioned related to mbstring is not a security fault, you know. Moriyoshi