Re: cvs: php-src /ext/standard file.c
| From: | Moriyoshi Koizumi | Date: | Sat, 03 Jan 2004 01:28:11 +0000 |
| Subject: | Re: cvs: php-src /ext/standard file.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-25514@lists.php.net to get a copy of this message | ||
On 2004/01/02, at 9:57, Ilia Alshanetsky wrote:
- if (len < 0) { - php_error_docref(NULL TSRMLS_CC, E_WARNING, "Length parameter may not be negative"); + if (len <= 0) { + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Length parameter must be greater then 0."); RETURN_FALSE; }I think this may cause a slight BC break, because they wouldn't raise warnings if the length is 0. How about returning FALSE silently in that case? Moriyoshi