Re: cvs: php-src /ext/standard file.c
| From: | Ilia Alshanetsky | Date: | Sat, 03 Jan 2004 01:36:27 +0000 |
| Subject: | Re: cvs: php-src /ext/standard file.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-25515@lists.php.net to get a copy of this message | ||
On January 02, 2004 08:28 pm, Moriyoshi Koizumi wrote:
> I think this may cause a slight BC break, because they wouldn't
> raise warnings if the length is 0. How about returning FALSE
> silently in that case?
fgets($fp, 0) is pretty pointless and should raise an error. If it does not
raise an error it makes spotting and resolving the problem that much more
difficult. With a clear warning fixing this issue in the code is much
simpler.
Ilia