Re: cvs: php-src /ext/standard file.c

From: Date: Sun, 04 Jan 2004 02:29:11 +0000
Subject: Re: cvs: php-src /ext/standard file.c
References: 1 2 3  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-25526@lists.php.net to get a copy of this message
On 2004/01/03, at 10:36, Ilia Alshanetsky wrote:
On January 02, 2004 08:28 pm, Moriyoshi Koizumi wrote:
I think this may cause a slight BC break, because they wouldn't raise warnings if the length is 0. How about returning FALSE silently in that case?
fgets($fp, 0) is pretty pointless and should raise an error. If it does not raise an error it makes spotting and resolving the problem that much more difficult. With a clear warning fixing this issue in the code is much simpler.
Well, the reasoning seems right to the point. But BC stuff is not necessarily involved in the semantics behind the function. Moriyoshi

« previous php.cvs (#25526) next »