Re: cvs: php4 /ext/standard datetime.c

At 01:36 PM 6/14/00 -0700, Rasmus Lerdorf wrote:

I really think that keeping it that way is not an option. It *will* break every script that uses checkdate() to verify form input. I'm not sure whether we should start testing for argument types wherever certain argument types don't make sense. There are hundreds if not thousands of such places. I don't agree that there are thousands. checkdate() is essentially an input checking function that checks to see if the arguments are within a certain range and just returns true/false. Somewhat like is_numeric(). I think with the latest fix it makes sense.

What doesn't make sense is that you are only checking the year and not the others. Right now it looks like one inconsistent function internally. Let's decide on a way to deal with all three parameters and stick to it. Andi --- Andi Gutmans <andi@zend.com> http://www.zend.com/