Re: cvs: php4 /ext/standard datetime.c
| From: | Andi Gutmans | Date: | Wed, 14 Jun 2000 20:42:08 +0000 |
| Subject: | Re: cvs: php4 /ext/standard datetime.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-274@lists.php.net to get a copy of this message | ||
Not in my opinion. I don't see why checking the year but not month and day is OK.
In this case all should be checked.
Andi
At 11:37 PM 6/14/00 +0200, Zeev Suraski wrote:
Yeah, with the last fix it's ok. Zeev At 22:36 14/06/2000, Rasmus Lerdorf wrote: I really think that keeping it that way is not an option. It *will* break every script that uses checkdate() to verify form input. I'm not sure whether we should start testing for argument types wherever certain argument types don't make sense. There are hundreds if not thousands of such places.--- Andi Gutmans <andi@zend.com> http://www.zend.com/I don't agree that there are thousands. checkdate() is essentially an input checking function that checks to see if the arguments are within a certain range and just returns true/false. Somewhat like is_numeric(). I think with the latest fix it makes sense. -Rasmus-- Zeev Suraski <zeev@zend.com> http://www.zend.com/