Re: cvs: php4 /ext/standard datetime.c

From: Date: Wed, 14 Jun 2000 21:28:18 +0000
Subject: Re: cvs: php4 /ext/standard datetime.c
References: 1  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-279@lists.php.net to get a copy of this message
> What doesn't make sense is that you are only checking the year and not the > others. Right now it looks like one inconsistent function internally. > Let's decide on a way to deal with all three parameters and stick to it. I explained that. To be truly consistent I suppose I should be performing the same checks on the day and month arguments, but it would only be to make the code look consistent. Functionally it makes no difference since a non-numeric string evaluates to 0 when converted to a long and since 0 is an invalid value for both the day and the month arguments, adding the extra checks would be redundant. -Rasmus

« previous php.cvs (#279) next »