Re: cvs: php4 /ext/standard file.c

At 17:34 23/12/2000, Sascha Schumann wrote:

Most module will simply display it as an error as well, if they handle it at all. So worst case - we'll be overriding their error reporting function, or they'd be overriding ours. No biggy in both cases.

    Our handler would somehow have to be able to restore the
    context to a defined state (i.e. to reenter the main Apache
    loop and to cleanup the left-overs of the other module).  How
    would a PHP handler achieve that?

Actually, we can easily detect if we're during the course of a PHP request, and only run our code if we are, or call the original signal handler otherwise.

(d) If you think that it's still likely we'll interfere with the core behavior of other modules, we can always turn on our signal trapping on request startup and restore the original signal handle on request shutdown. I don't think it's necessary though.

    That sounds like a very expensive operation.

True, which is why I said it'll only make sense to do it if other modules actually do special things (such as cleanups and that sort of stuff) while handling this situation. I find this very unlikely, but who knows, perhaps some modules work that way. My above suggestion will take care of this as well. Zeev -- Zeev Suraski <zeev@zend.com> CTO & co-founder, Zend Technologies Ltd. http://www.zend.com/