Re: cvs: php4 / NEWS /ext/dba dba.c dba_db2.c dba_db3.c php_dba.h

On Tue, 27 Jun 2000, Jouni Ahto wrote: > jah Tue Jun 27 14:36:26 2000 EDT > > Modified files: > /php4 NEWS > /php4/ext/dba dba.c dba_db2.c dba_db3.c php_dba.h > Log: > > - dba_[p]open accepts now a new parameter, which kind of database to create > (DBA_BTREE or DBA_HASH), if the handler is either 'db2' or 'db3' and > mode 'c' or 'n'. It is ignored if mode is 'c' and the db > already exists. > # Asked on the list 4 1/2 hours ago if anyone's got to say something to this, > # no response, so I'm assuming it's ok. And yes, I did test this. -1 on including this patch in 4.0.1. The patch should have been discussed first on the mailing list. We are trying to stabilize PHP before a release, so don't commit any feature patches without posting them to the list before. The patch is unclean, because it adds duplicate code and does not update the GDBM back-end. So, please back out the patch. - Sascha