Re: cvs: php4 / NEWS /ext/dba dba.c dba_db2.c dba_db3.c php_dba.h
| From: | jah at mork dot net | Date: | Tue, 27 Jun 2000 22:59:09 +0000 |
| Subject: | Re: cvs: php4 / NEWS /ext/dba dba.c dba_db2.c dba_db3.c php_dba.h | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-522@lists.php.net to get a copy of this message | ||
On Wed, 28 Jun 2000, Sascha Schumann wrote:
> -1 on including this patch in 4.0.1.
>
> The patch should have been discussed first on the mailing
> list. We are trying to stabilize PHP before a release, so
> don't commit any feature patches without posting them to the
> list before.
>
> The patch is unclean, because it adds duplicate code and does
> not update the GDBM back-end.
>
> So, please back out the patch.
Ok, backed out. Let's return to this topic after 4.0.1 is out.
But why should the GDBM backend have been touched? It doesn't support
more than one format. Or am I missing something?
- Jouni