Re: cvs: php4 / NEWS /ext/dba dba.c dba_db2.c dba_db3.c php_dba.h

On Wed, 28 Jun 2000 jah@mork.net wrote: > > > On Wed, 28 Jun 2000, Sascha Schumann wrote: > > > -1 on including this patch in 4.0.1. > > > > The patch should have been discussed first on the mailing > > list. We are trying to stabilize PHP before a release, so > > don't commit any feature patches without posting them to the > > list before. > > > > The patch is unclean, because it adds duplicate code and does > > not update the GDBM back-end. > > > > So, please back out the patch. > > Ok, backed out. Let's return to this topic after 4.0.1 is out. Thanks. > But why should the GDBM backend have been touched? It doesn't support > more than one format. Or am I missing something? Nope, I was sitting at a 80x25 terminal. Kinda sucks, if you try to find a specific piece of code. But nevertheless, I think we can make the patch more general. - Sascha