Re: cvs: php-src /ext/bz2 bz2_filter.c
| From: | Greg Beaver | Date: | Thu, 05 Feb 2009 14:56:22 +0000 |
| Subject: | Re: cvs: php-src /ext/bz2 bz2_filter.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-56107@lists.php.net to get a copy of this message | ||
Antony Dovgal wrote:
> On 03.02.2009 22:02, Greg Beaver wrote:
>
>> - php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu bytes",
>> sizeof(php_bz2_filter_data));
>> + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu bytes.",
>> sizeof(php_bz2_filter_data));
>> - php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu bytes",
>> data->inbuf_len);
>> + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu bytes.",
>> data->inbuf_len);
>> - php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu bytes",
>> data->outbuf_len);
>> + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu bytes.",
>> data->outbuf_len);
>>
>
> Huh? Why add more dots?
>
This was in PHP_5_3, no idea why it wasn't in HEAD, but it makes syncing
easier if they're the same. I don't care either way whether they have
periods or not, so feel free to revert if you feel strongly.
Thanks,
Greg