Re: cvs: php-src /ext/bz2 bz2_filter.c
| From: | Christopher Jones | Date: | Thu, 05 Feb 2009 21:47:49 +0000 |
| Subject: | Re: cvs: php-src /ext/bz2 bz2_filter.c | ||
| References: | 1 2 3 4 5 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-56117@lists.php.net to get a copy of this message | ||
Greg Beaver wrote:
Johannes Schlüter wrote:well, with dots they look like this in the end: "Warning: Failed allocating %zu bytes. in foo.php on line 42" Which certainly looks wrong. Therefore we don't put dots in the end :-) johannes I really don't give a crap. Change it if you want, I was merging *existing* code in PHP_5_3 to HEAD, not adding new stuff. It's no big deal. It caught my eye originally too, so I'll make the changes. Chris -- Email: christopher.jones@oracle.com Tel: +1 650 506 8630 Twitter: http://twitter.com/ghrd Free PHP Book: http://tinyurl.com/UGPOMOn Thu, 2009-02-05 at 08:56 -0600, Greg Beaver wrote:This was in PHP_5_3, no idea why it wasn't in HEAD, but it makes syncing easier if they're the same. I don't care either way whether they have periods or not, so feel free to revert if you feel strongly.Antony Dovgal wrote:Huh? Why add more dots?+ php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu bytes.", sizeof(php_bz2_filter_data)); - php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu bytes", data->inbuf_len); + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu bytes.", data->inbuf_len); - php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu bytes", data->outbuf_len); + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu bytes.", data->outbuf_len);On 03.02.2009 22:02, Greg Beaver wrote:- php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu bytes", sizeof(php_bz2_filter_data));