Re: cvs: php-src /ext/bz2 bz2_filter.c

On Thu, 2009-02-05 at 08:56 -0600, Greg Beaver wrote: > Antony Dovgal wrote: > > On 03.02.2009 22:02, Greg Beaver wrote: > > > >> - php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu > >> bytes", sizeof(php_bz2_filter_data)); > >> + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu > >> bytes.", sizeof(php_bz2_filter_data)); > >> - php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu > >> bytes", data->inbuf_len); > >> + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu > >> bytes.", data->inbuf_len); > >> - php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu > >> bytes", data->outbuf_len); > >> + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating %zu > >> bytes.", data->outbuf_len); > >> > > > > Huh? Why add more dots? > > > > This was in PHP_5_3, no idea why it wasn't in HEAD, but it makes syncing > easier if they're the same. I don't care either way whether they have > periods or not, so feel free to revert if you feel strongly. well, with dots they look like this in the end: "Warning: Failed allocating %zu bytes. in foo.php on line 42" Which certainly looks wrong. Therefore we don't put dots in the end :-) johannes