Re: cvs: php4 /ext/standard image.c

On Wed, May 16, 2001 at 04:50:50AM -0000, Jani Taskinen wrote: > sniper Tue May 15 21:50:50 2001 EDT > > Modified files: > /php4/ext/standard image.c > Log: > Fixed bugs: #10297, #10615, #10783, #10880 > > > Index: php4/ext/standard/image.c > diff -u php4/ext/standard/image.c:1.31 php4/ext/standard/image.c:1.32 > --- php4/ext/standard/image.c:1.31 Thu May 3 23:25:10 2001 > +++ php4/ext/standard/image.c Tue May 15 21:50:49 2001 > @@ -15,7 +15,7 @@ > | Authors: Rasmus Lerdorf | > +----------------------------------------------------------------------+ > */ > -/* $Id: image.c,v 1.31 2001/05/04 06:25:10 sbergmann Exp $ */ > +/* $Id: image.c,v 1.32 2001/05/16 04:50:49 sniper Exp $ */ > /* > * Based on Daniel Schmitt's imageinfo.c which carried the following > * Copyright notice. > @@ -241,15 +241,6 @@ > /* get next marker byte from file */ > { > int c; > - > - /* skip unimportant stuff */ > - > - c = FP_FGETC(socketd,fp,issock); > - > - while (c != 0xff) { > - if ((c = FP_FGETC(socketd,fp,issock)) == EOF) > - return M_EOI; /* we hit EOF */ > - } > are you sure this is a wise thing to do? this code has been more-or-less taken from the ijg-jpeg and has been in there as long as this (getimagesize) function exists. could you send me a failing sample-image so i could see myself? re, tc > /* get marker byte, swallowing possible padding */ > do { > > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, e-mail: php-cvs-unsubscribe@lists.php.net > For additional commands, e-mail: php-cvs-help@lists.php.net > To contact the list administrators, e-mail: php-list-admin@lists.php.net >