Re: cvs: php4 /ext/standard image.c
| From: | Jani Taskinen | Date: | Wed, 16 May 2001 06:23:24 +0000 |
| Subject: | Re: cvs: php4 /ext/standard image.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-5768@lists.php.net to get a copy of this message | ||
On Wed, 16 May 2001, Thies C. Arntzen wrote:
>> {
>> int c;
>> -
>> - /* skip unimportant stuff */
>> -
>> - c = FP_FGETC(socketd,fp,issock);
>> -
>> - while (c != 0xff) {
>> - if ((c = FP_FGETC(socketd,fp,issock)) == EOF)
>> - return M_EOI; /* we hit EOF */
>> - }
>>
>
> are you sure this is a wise thing to do? this code has been
> more-or-less taken from the ijg-jpeg and has been in there as
> long as this (getimagesize) function exists. could you send
> me a failing sample-image so i could see myself?
The way it works after I made this function to accept URLs,
only removing this (since there can't be any fseek() now) works.
But if you can come up with better fix, feel free. :)
Attached one failing jpeg.
--Jani