Re: cvs: php4 /ext/standard image.c

On Wed, May 16, 2001 at 12:12:21AM -0700, Rasmus Lerdorf wrote: > > the problem is that now we start parsing the jpeg-file with a > > 3-byte offset and not from the beginning. this was changed in > > order to allow GetImageSize work on remote images (no fseek() > > possible). > > > > i'm just not sure if this change(s alltogeter) won't break on > > other valid jpeg-images. > > > > the clean approach would be to buffer the 3 bytes that we > > need to identify the image as a jpeg and feed them back into > > the next_marker functions somehow. > > But there can't really be a marker in the first 3 bytes, can there? i kinda agree - but the code was in there for a reason i suppose. i think we can just ignore it for now and see if people start complaining about some other JPEGs not working any more (that used to work). tc