Re: cvs: php4 /ext/aspell aspell.c /ext/bcmath bcmath.c /ext/bz2 bz2.c /ext/calendar cal_unix.c calendar.c dow.c french.c jewish.c julian.c
/ext/ccvs ccvs.c /ext/cpdf cpdf.c /ext/crack

SS>> Wtf? Lines should not be longer than 78 chars. -1 on this SS>> change. I disagree. For code, breaking line is in many cases no good at all. Example (from zend_execute.c, just open in my editor :) temp_variable *Ts = (temp_variable *) do_alloca(sizeof(temp_variable)*op_array->T); Breaking this line like this: temp_variable *Ts = (temp_variable *) do_alloca(sizeof(temp_variable)*op_array->T); doesn't do much good. Now take in account the indentation and imagine this line is on fourth or fifth level (+20 chars). -- Stanislav Malyshev, Zend Products Engineer stas@zend.com http://www.zend.com/ +972-3-6139665 ext.115