Re: com php-src: Fix ext/pgsql builds with libpq < 7.3.: NEWS ext/pgsql/pgsql.c

On 2 July 2014 02:09, Matteo Beccati <php@beccati.com> wrote: > > On 01/07/2014 22:19, Adam Harvey wrote: > > Commit: 899fe3d8af42dc09c3f0ed2915e516c068166a43 > > Author: Adam Harvey <aharvey@php.net> Tue, 1 Jul 2014 13:19:22 -0700 > > Parents: 6081dd781aa78f2c6b6497ecba6f8c4b88fc5afb > > Branches: PHP-5.4 PHP-5.5 PHP-5.6 master > > > > Link: > > http://git.php.net/?p=php-src.git;a=commitdiff;h=899fe3d8af42dc09c3f0ed2915e516c068166a43 > > > > Log: > > Fix ext/pgsql builds with libpq < 7.3. > > Thanks for the fix. However, wouldn't it be about time -- at least in > master -- to drop support for libpq versions that reached end-of-life > already, at least the ones that have only unsafe escaping? Looking at 5.6 and master, I think this has basically happened already by accident, as we appear to be relying on newer features — someone will probably need to figure out what our real minimum version is now and document it (and put a more explicit test into config.m4). I don't mind doing that, but I was just trying to get the quick fix in yesterday while I had a spare ten minutes. Adam