Re: com php-src: Fix ext/pgsql builds with libpq < 7.3.: NEWS ext/pgsql/pgsql.c

On 2 July 2014 12:00, Matteo Beccati <php@beccati.com> wrote: > On 02/07/2014 19:27, Adam Harvey wrote: >> On 2 July 2014 02:09, Matteo Beccati <php@beccati.com> wrote: >>> Thanks for the fix. However, wouldn't it be about time -- at least in >>> master -- to drop support for libpq versions that reached end-of-life >>> already, at least the ones that have only unsafe escaping? >> >> Looking at 5.6 and master, I think this has basically happened already >> by accident, as we appear to be relying on newer features — someone >> will probably need to figure out what our real minimum version is now >> and document it (and put a more explicit test into config.m4). I don't >> mind doing that, but I was just trying to get the quick fix in >> yesterday while I had a spare ten minutes. > > For pdo_pgsql, I bumped the requirements and cleaned up the code already > for 5.6. However ext/pgsql is what legacy postgres users most likely are > using, so I didn't touch it at that time. Your commit simply reminded me > that we probably should address that at some point :) On closer examination, it looks like we're only one #ifdef away from supporting at least 7.3 once again in 5.6 and master, so I'm going to commit that for now. (I can't actually compile PostgreSQL 7.2 or earlier, but I suspect it'll fix them as well.) PostgreSQL 7.4 and later worked already. That said, I'm totally OK with bumping the minimum version requirement for ext/pgsql in master: 8.0 or 8.1 seem reasonable (even CentOS 5 has 8.1). It seems like 8.0 is now the implicit requirement for pdo_pgsql? Adam