Re: com php-src: Fix ext/pgsql builds with libpq < 7.3.: NEWS ext/pgsql/pgsql.c

On 02/07/2014 19:27, Adam Harvey wrote: > On 2 July 2014 02:09, Matteo Beccati <php@beccati.com> wrote: >> Thanks for the fix. However, wouldn't it be about time -- at least in >> master -- to drop support for libpq versions that reached end-of-life >> already, at least the ones that have only unsafe escaping? > > Looking at 5.6 and master, I think this has basically happened already > by accident, as we appear to be relying on newer features — someone > will probably need to figure out what our real minimum version is now > and document it (and put a more explicit test into config.m4). I don't > mind doing that, but I was just trying to get the quick fix in > yesterday while I had a spare ten minutes. For pdo_pgsql, I bumped the requirements and cleaned up the code already for 5.6. However ext/pgsql is what legacy postgres users most likely are using, so I didn't touch it at that time. Your commit simply reminded me that we probably should address that at some point :) Cheers -- Matteo Beccati Development & Consulting - http://www.beccati.com/