Re: com php-src: Reclassify E_STRICT notices: Zend/tests/009.phpt Zend/tests/abstract-static.phpt Zend/tests/argument_restriction_001.phpt
Zend/tests/argument_restriction_002.phpt Zend/tests/argument_restriction_003.phpt Zend/tests/argument_restriction_006.phpt Zend/tests/bug30820.phpt
Zend/tests/bug31525.phpt Zend/tests/bug32322.phpt Zend/tests/bug33257.phpt Zend/tests/bug35393.phpt Zend/tests/bug40621.phpt Zend/tests/bug45805.phpt
Zend/tests/bug470
| From: | Dmitry Stogov | Date: | Thu, 02 Apr 2015 00:41:30 +0000 |
| Subject: | Re: com php-src: Reclassify E_STRICT notices: Zend/tests/009.phpt Zend/tests/abstract-static.phpt Zend/tests/argument_restriction_001.phpt Zend/tests/argument_restriction_002.phpt Zend/tests/argument_restriction_003.phpt Zend/tests/argument_restriction_006.phpt Zend/tests/bug30820.phpt Zend/tests/bug31525.phpt Zend/tests/bug32322.phpt Zend/tests/bug33257.phpt Zend/tests/bug35393.phpt Zend/tests/bug40621.phpt Zend/tests/bug45805.phpt Zend/tests/bug470 |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-86037@lists.php.net to get a copy of this message | ||
This patch made some performance degradation on inheritance code :(
If previously on 100 requests to Wordpress
zend_do_perform_implementation_check() was called 684 times, now it's
called 8,784 times.
This may cause more serious degradation on big OO frameworks.
The same trick with checking for E_WARNING in EG(error_reporing) doesn't
work as before (at least on Wordpress).
Thanks. Dmitry.
On Wed, Apr 1, 2015 at 12:17 PM, Nikita Popov <nikic@php.net> wrote:
> Commit: 8d00385871c6dca1f18a5e7924c655a2cb381564
> Author: Nikita Popov <nikic@php.net> Sun, 15 Mar 2015 09:47:25
> +0100
> Parents: 4796e0242b8cdd2a77b552fcbaa74d70d87f6d0a
> Branches: master
>
> Link:
>
> http://git.php.net/?p=php-src.git;a=commitdiff;h=8d00385871c6dca1f18a5e7924c655a2cb381564
>
> Log:
> Reclassify E_STRICT notices
>
> Per RFC https://wiki.php.net/rfc/reclassify_e_strict
>
> While reviewing this, found that there are still three E_STRICTs
> left in libraries - need to discuss those.
>
> Changed paths:
> M Zend/tests/009.phpt
> M Zend/tests/abstract-static.phpt
> M Zend/tests/argument_restriction_001.phpt
> M Zend/tests/argument_restriction_002.phpt
> M Zend/tests/argument_restriction_003.phpt
> M Zend/tests/argument_restriction_006.phpt
> M Zend/tests/bug30820.phpt
> M Zend/tests/bug31525.phpt
> M Zend/tests/bug32322.phpt
> M Zend/tests/bug33257.phpt
> M Zend/tests/bug35393.phpt
> M Zend/tests/bug40621.phpt
> M Zend/tests/bug45805.phpt
> M Zend/tests/bug47054.phpt
> M Zend/tests/bug48533.phpt
> M Zend/tests/bug60536_002.phpt
> M Zend/tests/bug60536_004.phpt
> M Zend/tests/bug60536_005.phpt
> M Zend/tests/bug60573.phpt
> M Zend/tests/bug62358.phpt
> M Zend/tests/bug63111.phpt
> M Zend/tests/bug63336.phpt
> M Zend/tests/bug64988.phpt
> M Zend/tests/bug65322.phpt
> M Zend/tests/bug67436/bug67436_nohandler.phpt
> M Zend/tests/call_static_006.phpt
> M Zend/tests/call_user_func_004.phpt
> M Zend/tests/call_user_func_005.phpt
> M Zend/tests/callable_type_hint_001.phpt
> M Zend/tests/errmsg_018.phpt
> M Zend/tests/errmsg_045.phpt
> M Zend/tests/fr47160.phpt
> M Zend/tests/objects_002.phpt
> M Zend/tests/objects_003.phpt
> M Zend/tests/objects_004.phpt
> M Zend/tests/objects_005.phpt
> M Zend/tests/objects_006.phpt
> M Zend/tests/objects_007.phpt
> M Zend/tests/objects_008.phpt
> M Zend/tests/objects_009.phpt
> M Zend/tests/objects_027.phpt
> M Zend/tests/offset_array.phpt
> M Zend/tests/strict_001.phpt
> M Zend/tests/strict_002.phpt
> M Zend/tests/traits/property001.phpt
> M Zend/tests/traits/property005.phpt
> M Zend/tests/traits/property006.phpt
> M Zend/tests/traits/property007.phpt
> M Zend/tests/traits/property009.phpt
> M Zend/zend_API.c
> M Zend/zend_API.h
> M Zend/zend_compile.c
> M Zend/zend_execute.c
> M Zend/zend_execute_API.c
> M Zend/zend_inheritance.c
> M Zend/zend_object_handlers.c
> M Zend/zend_vm_def.h
> M Zend/zend_vm_execute.h
> M ext/session/tests/session_encode_error2.phpt
> M ext/spl/spl_array.c
> M ext/spl/tests/bug62978.phpt
> M ext/standard/tests/array/array_map_object1.phpt
> M ext/standard/tests/array/array_next_error1.phpt
> M ext/standard/tests/array/array_shift_variation5.phpt
> M ext/standard/tests/array/array_shift_variation8.phpt
> M ext/standard/tests/array/bug39576.phpt
> M ext/standard/tests/array/prev_error2.phpt
> M ext/standard/tests/assert/assert_variation.phpt
> M ext/standard/tests/filters/php_user_filter_01.phpt
> M ext/standard/tests/filters/php_user_filter_02.phpt
> M ext/standard/tests/filters/php_user_filter_03.phpt
> M ext/standard/tests/general_functions/bug32647.phpt
> M ext/standard/tests/general_functions/bug47857.phpt
> M tests/classes/abstract_static.phpt
> M tests/classes/clone_006.phpt
> M tests/classes/inheritance_003.phpt
> M tests/classes/inheritance_004.phpt
> M tests/classes/method_override_optional_arg_001.phpt
> M tests/classes/method_override_optional_arg_002.phpt
> M tests/classes/static_properties_003.phpt
> M tests/classes/type_hinting_005a.phpt
> M tests/classes/type_hinting_005b.phpt
> M tests/classes/type_hinting_005c.phpt
> M tests/classes/type_hinting_005d.phpt
> M tests/lang/bug20175.phpt
> M tests/lang/bug21600.phpt
> M tests/lang/bug23384.phpt
> M tests/lang/passByReference_004.phpt
> M tests/lang/passByReference_005.phpt
> M tests/lang/passByReference_006.phpt
> M tests/lang/passByReference_007.phpt
> M tests/lang/passByReference_010.phpt
> M tests/lang/passByReference_012.phpt
> M tests/lang/returnByReference.002.phpt
> M tests/lang/returnByReference.003.phpt
> M tests/lang/returnByReference.004.phpt
> M tests/lang/returnByReference.005.phpt
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>