Re: com php-src: Reclassify E_STRICT notices: Zend/tests/009.phpt Zend/tests/abstract-static.phpt Zend/tests/argument_restriction_001.phpt
Zend/tests/argument_restriction_002.phpt Zend/tests/argument_restriction_003.phpt Zend/tests/argument_restriction_006.phpt Zend/tests/bug30820.phpt
Zend/tests/bug31525.phpt Zend/tests/bug32322.phpt Zend/tests/bug33257.phpt Zend/tests/bug35393.phpt Zend/tests/bug40621.phpt Zend/tests/bug45805.phpt
Zend/tests/bug470
| From: | Dmitry Stogov | Date: | Thu, 02 Apr 2015 09:00:14 +0000 |
| Subject: | Re: com php-src: Reclassify E_STRICT notices: Zend/tests/009.phpt Zend/tests/abstract-static.phpt Zend/tests/argument_restriction_001.phpt Zend/tests/argument_restriction_002.phpt Zend/tests/argument_restriction_003.phpt Zend/tests/argument_restriction_006.phpt Zend/tests/bug30820.phpt Zend/tests/bug31525.phpt Zend/tests/bug32322.phpt Zend/tests/bug33257.phpt Zend/tests/bug35393.phpt Zend/tests/bug40621.phpt Zend/tests/bug45805.phpt Zend/tests/bug470 |
||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-86046@lists.php.net to get a copy of this message | ||
In production these checks were usually omitted because E_STRICT wasn't set
by default (see php.ini-production).
; error_reporting
; Default Value: E_ALL & ~E_NOTICE & ~E_STRICT & ~E_DEPRECATED
; Development Value: E_ALL
; Production Value: E_ALL & ~E_DEPRECATED & ~E_STRICT
Now we will have to check each overridden function.
Wordpress doesn't use a lot of inherited classes so it's affected
insignificantly.
Big OO frameworks may be affected more.
Thanks. Dmitry.
On Thu, Apr 2, 2015 at 11:39 AM, Nikita Popov <nikita.ppv@gmail.com> wrote:
> On Thu, Apr 2, 2015 at 2:41 AM, Dmitry Stogov <dmitry@zend.com> wrote:
>
>> This patch made some performance degradation on inheritance code :(
>> If previously on 100 requests to Wordpress
>> zend_do_perform_implementation_check() was called 684 times, now it's
>> called 8,784 times.
>> This may cause more serious degradation on big OO frameworks.
>>
>> The same trick with checking for E_WARNING in EG(error_reporing) doesn't
>> work as before (at least on Wordpress).
>>
>> Thanks. Dmitry.
>>
>
> Just checked, it increases instruction count by 0.05% for me as well. I
> don't think this problem will affect OO frameworks - they don't disable
> error_reporting, like WP seems to do for E_DEPRECATED and E_STRICT, so
> they'll be doing those checks anyway.
>
> It's probably possible to optimize perfom_implementation_check a tiny bit
> for the case where the function has no typehints - not sure it's worthwhile.
>
> Nikita
>