Re: com php-src: Reclassify E_STRICT notices: Zend/tests/009.phpt Zend/tests/abstract-static.phpt Zend/tests/argument_restriction_001.phpt
Zend/tests/argument_restriction_002.phpt Zend/tests/argument_restriction_003.phpt Zend/tests/argument_restriction_006.phpt Zend/tests/bug30820.phpt
Zend/tests/bug31525.phpt Zend/tests/bug32322.phpt Zend/tests/bug33257.phpt Zend/tests/bug35393.phpt Zend/tests/bug40621.phpt Zend/tests/bug45805.phpt
Zend/tests/bug470
| From: | Dmitry Stogov | Date: | Thu, 02 Apr 2015 15:17:41 +0000 |
| Subject: | Re: com php-src: Reclassify E_STRICT notices: Zend/tests/009.phpt Zend/tests/abstract-static.phpt Zend/tests/argument_restriction_001.phpt Zend/tests/argument_restriction_002.phpt Zend/tests/argument_restriction_003.phpt Zend/tests/argument_restriction_006.phpt Zend/tests/bug30820.phpt Zend/tests/bug31525.phpt Zend/tests/bug32322.phpt Zend/tests/bug33257.phpt Zend/tests/bug35393.phpt Zend/tests/bug40621.phpt Zend/tests/bug45805.phpt Zend/tests/bug470 |
||
| References: | 1 2 3 4 5 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-86055@lists.php.net to get a copy of this message | ||
On Thu, Apr 2, 2015 at 5:07 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:
> On Thu, Apr 2, 2015 at 11:00 AM, Dmitry Stogov <dmitry@zend.com> wrote:
>
>> In production these checks were usually omitted because E_STRICT wasn't
>> set by default (see php.ini-production).
>>
>> ; error_reporting
>> ; Default Value: E_ALL & ~E_NOTICE & ~E_STRICT & ~E_DEPRECATED
>> ; Development Value: E_ALL
>> ; Production Value: E_ALL & ~E_DEPRECATED & ~E_STRICT
>>
>> Now we will have to check each overridden function.
>> Wordpress doesn't use a lot of inherited classes so it's affected
>> insignificantly.
>> Big OO frameworks may be affected more.
>>
>
> Good point, I wasn't aware we suggest to disable E_DEPRECATED/E_STRICT in
> production. I'm not sure what to do about this - I don't think relying on
> error_reporting setting to avoid the cost of inheritance checks really
> makes sense.
>
I'm not sure as well :(
Thanks. Dmitry.
>
> Nikita
>