Re: PHP_31 define?

> While we're at it, when can we bring the 3.1 to be uptodate with the 3.0 > tree as far as modules are concerned? Anytime you want. It is a gradual process, obviously. I am currently doing LDAP and SNMP. The LDAP module isn't compiling because of the PHP_31 thing. I have added -DPHP_31 to CFLAGS and it should go now, but do we even want such a define? I'd rather see some sort of API version numbering similar to Apache's so instead of the current: #if PHP_31 #include "ext/standard/php3_string.h" #else #include "functions/php3_string.h" #endif We would have: #if PHP_API_MAGIC_NUMBER > 3119980919 #include "ext/standard/php3_string.h" #else #include "functions/php3_string.h" #endif Or in this case we might just check that it is >3100000000 to indicate that this change was made in the 3.0 to 3.1 change. This should make it possible to write a module which compiles with all versions of PHP. -Rasmus -- PHP Development Mailing List http://www.php.net/ To unsubscribe send an empty message to php-dev-unsubscribe@lists.php.net For help: php-dev-help@lists.php.net