Re: Name for new function

At 18:47 16-07-00, Derick Rethans wrote:

Derick Rethans wrote: Zeev Suraski wrote:

Don't you think this sort of emulation belongs in user space

scripts? It'd

be much less prone to bugs.

It could be more prone to bugs, but I think that's not a great problem. I tried to write the code as clean as possible. However, I think that this approach is much faster then emulation in user space. I'll run some tests tomorrow. I'll post the results on the list. It seems that the function written in C code is about 15-20% faster than the implementation in user-space PHP. I think it's significant enough. My plan is to commit the patch to cvs within a few days. (I have to do some tweaking at some places).

IMHO it's not significant enough to be worth more C code to maintain, and should be given as a PHP code snippet. C code is worth it only when it gives you an order of magnitude (10x faster or more). I'm interested to know what others think about it, though; If others think it belongs in the low level module, I won't be the party crasher. Zeev -- Zeev Suraski <zeev@zend.com> http://www.zend.com/