Re: Name for new function

Derick Rethans wrote: > It seems that the function written in C code is about 15-20% faster than the > implementation in user-space PHP. I think it's significant enough. My plan is to > commit the patch to cvs within a few days. (I have to do some tweaking at some > places). Why did you write it as a PHP extension, and not as a MySQL extension? By doing what you did, you will generate hideously inefficient queries, because they are run at the wrong side of the client-server chasm. You will cement that wrongness by adding it to the PHP/MySQL extension core. Other people will use it, and future scripts will depend on it, making it necessary to keep your extension even after it has been made obsolete by doing it the right way within the MySQL server. Without looking at your code at all, I vote that your patch be rejected for architectural and strategic reasons. Kristian -- Kristian Köhntopp, NetUSE AG Siemenswall, D-24107 Kiel Tel: +49 431 386 436 00, Fax: +49 431 386 435 99 Using PHP3? See our web development library at http://phplib.netuse.de/