Re: New zend_compile.c to solve all of the duplicate function problems

On Thu, 18 Oct 2001, Brian Moon wrote: > Ok, > > I played with the code in zend_compile.c last night and came up with this > solution. The attached file will only issue a NOTICE for duplicate > functions from the same line and file. It will still issue an ERROR for > duplicate functions of a different file or line number. In either case, > zend_hash_add is never called because zend_hash_find is called first. > Therefore the function is never added to the hash table and the first > version of the function is what is used. > > I tested this code against the old with a file with 100000 functions in it. > There is no noticeable speed difference. > > I think this may solve all of the problems. Uh, thanks for the 92k attachment. It would have been enough to send a diff. -Andrei * "UNIX, isn't that some archaic form of DOS?" - our job applicant *