Re: cvs: php4 /ext/session session.c
On Sun, 30 Dec 2001, Yasuo Ohgaki wrote:
> yohgaki Sat Dec 29 20:37:24 2001 EDT
>
> Modified files:
> /php4/ext/session session.c
> Log:
> Get rid of error message
> # These lines should be enabled when save handlers can be initialized
> # before session module initialization.
I don't think it's a good idea to comment this. IMO, fix the issue first
before disabling correct code. Please revert this.
Derick
>
>
> Index: php4/ext/session/session.c
> diff -u php4/ext/session/session.c:1.268 php4/ext/session/session.c:1.269
> --- php4/ext/session/session.c:1.268 Tue Dec 25 20:55:54 2001
> +++ php4/ext/session/session.c Sat Dec 29 20:37:23 2001
> @@ -17,7 +17,7 @@
> +----------------------------------------------------------------------+
> */
>
> -/* $Id: session.c,v 1.268 2001/12/26 01:55:54 yohgaki Exp $ */
> +/* $Id: session.c,v 1.269 2001/12/30 01:37:23 yohgaki Exp $ */
>
> #ifdef HAVE_CONFIG_H
> #include "config.h"
> @@ -115,9 +115,12 @@
> static PHP_INI_MH(OnUpdateSaveHandler)
> {
> PS(mod) = _php_find_ps_module(new_value TSRMLS_CC);
> - if(!PS(mod)) {
> - php_error(E_ERROR,"Cannot find save handler %s",new_value);
> - }
> +/* Following lines are commented out to prevent bogus error message at
> + start up. i.e. Save handler modules are not initilzied before Session
> + module. */
> +/* if(!PS(mod)) { */
> +/* php_error(E_ERROR,"Cannot find save handler %s",new_value); */
> +/* } */
> return SUCCESS;
> }
>
>
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, e-mail: php-cvs-unsubscribe@lists.php.net
> For additional commands, e-mail: php-cvs-help@lists.php.net
> To contact the list administrators, e-mail: php-list-admin@lists.php.net
>
Thread (11 messages)