Re: cvs: php4 /ext/session session.c

From: Date: Sun, 06 Jan 2002 23:59:46 +0000
Subject: Re: cvs: php4 /ext/session session.c
References: 1 2  Groups: php.dev 
Request: Send a blank email to php-dev+get-76103@lists.php.net to get a copy of this message 
derick@php.net wrote:


On Thu, 3 Jan 2002, Yasuo Ohgaki wrote:



Which is perfectly fine as it is IMO. What is the change here that you
suggest exactly?



- Do not use php_session_register_module()
- Add #ifdef to ps_modules struct for external save
  handler modules



You want to add the pgsql module here too then?



Depends, since there is no real users and there is no
way to download other than check out from CVS :)





Just a few lines of changes, but it requries to compile save handler
modules with session module.




I'm against removing the php_session_register_module() call, for the
reason that I need it for SRM. Sascha implemented it because if this
(maybe partly) reason. If this call is removed, or deprecated, there is no
way for an extension to register a session module, without modifying the
PHP Source, which is a bad idea IMO.



php_session_register_module() should be there.
I'm proposing temp work around for known problem, since real fix would
take much longer time to implement.





You still failed to tell me why this is all needed. If it's only the
runtime undefined symbol stuff, then I think it's nto worth the hassle to
'fix' it. It's not broken now. And I think it's not that big a problem at
all.


That's why I just get rid of error message for now.

Should I leave it as is?



That's my opinion here.



Ok. Then I just leave the session.c as is now. (No error message for
bogus session save handler name. All external save handlers are bogus
when module is initilized :)

I've changed session.c so that it won't segfault under certain
condition when external session save handler is used. These
changes should be enough for now.

-- 
Yasuo Ohgaki

Thread (11 messages)

« previous php.dev (#76103) next »