Re: cvs: php4 /ext/session session.c

Yasuo Ohgaki wrote:

derick@php.net wrote:

On Sun, 30 Dec 2001, Yasuo Ohgaki wrote:

yohgaki        Sat Dec 29 20:37:24 2001 EDT

Modified files:

   /php4/ext/session    session.c

Log: Get rid of error message # These lines should be enabled when save handlers can be initialized # before session module initialization.

I don't think it's a good idea to comment this. IMO, fix the issue first before disabling correct code. Please revert this.

Ok. No problem, since I totally agree with you :) This patch closes some bug reports for mm save handler, though. We have to decide what kind of solution for module dependency we adopt. I can think of following solutions 1) "Start ini parser/module loader" that understand module dependency.

Oops. "Smart ini parser/module loader..."

2) Change session module so that it does not require save handlers are loaded before. 3) Compile related module at once (i.e. Use #ifdef) 4) Make session module a normal module. 5) Others? 1) is hard to implement although I prefer 1). This may have problem with 3rd party modules, so there should be standard place/format to hold module dependency info. 2) is not hard, but requires more coding than 3). 3) requires only a few lines of changes. 3) is the easiest choice, unless others have better/easier ideas. Anyone? 4) is probably not a good idea. 5) is open to everyone :) I would like to solve session module problem with 3), if nobody objects.

BTW, if I fix the issue with 3), I have to change msession a line so that it does not register it as session save handler. (handler is registered by #ifdef) I have to move pgsql session save handler to php4 source tree, since save handlers must be compiled with session module with option 3). Comments are welcome :) -- Yasuo Ohgaki