RE: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/msession msession.c
| From: | James Cox | Date: | Tue, 05 Feb 2002 15:11:22 +0000 |
| Subject: | RE: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/msession msession.c | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-79232@lists.php.net to get a copy of this message | ||
Mark,
revert your patch, or i'll do it for you.
you have removed code that makes it work for 4.x-dev, which is a complete
no-no, so that it will maintain BC that was there anyway.
Ideally, this code should probably be in PEAR/pecl, however if you wish to
keep it in php4/ext then revert the code and leave it as it is in HEAD, and
commit your code and tag it to 4.0.6. that way you can checkout 4.0.6 code.
In a professional environment (to quote you) you do not checkin code that
reverts working code without an extremely good reason. We have just fired
someone on a project i am working on for doing just that.
--james