Re: Re: cvs: php4 /ext/msession msession.c

mlwmohawk@mohawksoft.com wrote:

I wrapped the new parameter stuff in the #ifdef/#else/#endif because someone had put some work into it. I did not wish to remove someone else's effort.

effort appreciated, but you kept a cosmetical part of my while dropping the functional one, the proto comments that get evaluated by various documentation tools

just for the records: it was me who put in the final missing piece to make it all 4.0.6 compatible again in rev. 1.15 of msession.c

Thanks.

just to show that i don't completely ignore the BC issue ;)

and this time you've hit a nerve by reverting a patch needed for current dev version in favour of 4.0.6 compatibility AFAIK

What did I revert? What did I remove? If any functionality was removed, it was an error on my part. I had some local changes that I wanted to check in, and I needed 4.0.x compatibility so I could use it on my site.

sure, backwards compatibility is a "nice to have", but it's not our primary goal as far as extension source code is concerned

This sort of bothers me. Who is this "our" you talk about? As contributor of the msession extension, am I not also part of "our" and don't I get a say on the priorities of msession?

not if these priorities are in contradiction to the overall goals, and as such BC is not *that* important on a developement branch

I can understand your position, but the msession extension not a difficult peice of code. I have updated the proto comments so they correctly state what the functions do. Just tell me what else you want for comments.

the #ifdef OLD_ZEND_PARAM stuff obfuscates it without need, especially in the additional places where you use it like this #ifdef OLD_ZEND_PARAM

     php_log_err("Call to connect with non-null s_conn");

#else

     php_log_err("Call to connect with non-null s_conn" TSRMLS_CC);

#endif the behaviour you test for is not at all related to the parameter parsing functions, its just by coincidence that both are related to the same api version number switch -- Hartmut Holzgraefe hartmut@six.de http://www.six.de +49-711-99091-77 Wir stellen für Sie aus auf der CeBIT 2002 und freuen uns in Halle 6 auf Ihren Besuch am Stand H 18