Re: [PATCH] ext/bz2/bz2.c - fix mem overrun in _php_stream_bz2open in ZTS mode
| From: | Markus Fischer | Date: | Sat, 08 Jun 2002 02:01:26 +0000 |
| Subject: | Re: [PATCH] ext/bz2/bz2.c - fix mem overrun in _php_stream_bz2open in ZTS mode | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-85020@lists.php.net to get a copy of this message | ||
On Fri, May 31, 2002 at 11:32:14PM +0200, Markus Fischer wrote :
> The patch fixed that, but me being not that familiar with the
> things, I better let commit this someone who knows the code
> (Wez, Sterling?).
I was right, the patch is crap. But the problem still exists :)
estrdup()ing the path_copy from the virtual_filepath() seems
to be the proper fix, e.g.
#ifdef VIRTUAL_DIR
virtual_filepath(path, &path_copy_tmp TSRMLS_CC); // no error checking?
path_copy = estrdup(path_copy_tmp); // no error checking ?
#else
- Markus
--
GnuPG Key: http://guru.josefine.at/~mfischer/C2272BD0.asc