RE: [PHP-DEV] [PATCH] include statement in php.ini file
| From: | Preston L. Bannister | Date: | Fri, 27 Sep 2002 21:51:09 +0000 |
| Subject: | RE: [PHP-DEV] [PATCH] include statement in php.ini file | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-88696@lists.php.net to get a copy of this message | ||
I'd vote with Rasmus here. Adding an "include" statement (whatever it's
called) looks to be very low risk for inclusion in the 4.3 release.
I am a little uncomfortable with the auto-magic function to "include all
files in directory". I've been bitten more than a few times by "magic" that
didn't do exactly what was expected. Not clear where the balance between
risk and convenience falls in this case.
Put me down as +1 for including specific files, and -0.5 including entire
directories.
BTW - if entire directories are included then I think it *very* important
the directory/name of each INI actually used be remembered by PHP and
reported by phpinfo(). Otherwise folks doing support are going to have a
bit tougher time. On occasion we'd get stuck with the scenario where "it
should have worked, if this INI file was included, but I can't tell if it
was".
-----Original Message-----
From: Rasmus Lerdorf [mailto:rasmus@php.net]
Sent: Friday, September 27, 2002 11:01 AM
I'd like to see this in 4.3. It's not a huge change, and it is something
that would make my life easier now. I realize that is somewhat selfish,
but sometimes being selfish is good.
-Rasmus
> I would recommend to wait with committing this until after PHP_4_3_0 has
> been branches, and thus we have this nice and stable for PHP 5.
>
> Derick
>
> On Fri, 27 Sep 2002, David Viner wrote:
>
> > here is a revised patch that uses "additional_ini" keyword instead of
> > "include".
[snip]