Re: [PATCH] Changing entity charset handling in ext/standard/html.c
| From: | Wez Furlong | Date: | Wed, 16 Oct 2002 20:42:30 +0000 |
| Subject: | Re: [PATCH] Changing entity charset handling in ext/standard/html.c | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-89581@lists.php.net to get a copy of this message | ||
Unfortunately, we absolutely must remain 100% backwards compatible with
htmlentities(), so this patch should not be applied.
However, I don't see a problem with making phpinfo determine the charset
and passing that on to the internal htmlentities function?
--Wez.
On Thu, 17 Oct 2002, Moriyoshi Koizumi wrote:
> Hi,
>
> I know this may cause a potential BC problem, but I think htmlentities()
> should be more consistent with mbstring modules.
>
> The attached patch changes the behaviour of htmlentities() or its internal
> counterparts, to take the character set of the characters as the value of
> mbstring.internal_encoding, rather than iso-8859-1, when the charset
> parameter is not specified.
>
> And although it is not fully confirmed, this patch is also expected to fix
> the phpinfo() displaying problem in multibyte environments.
>
>
> Any comments are welcome.
>
> Moriyoshi Koizumi
>