Re: [PATCH] Changing entity charset handling
| From: | Yasuo Ohgaki | Date: | Thu, 17 Oct 2002 02:57:57 +0000 |
| Subject: | Re: [PATCH] Changing entity charset handling | ||
| References: | 1 2 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-89602@lists.php.net to get a copy of this message | ||
Wez Furlong wrote:
Search the archives for the discussion. phpinfo could determine the charset as your patch does at the start,phpinfo() better not to detect charsets, since user are using it to see variables' values. i.e. Variables may contains different encoding var to var. Applying htmlentities() to phpinfo() output prevents ability to change encoding on users(browser) side. Besides phpinfo() issue, I'm +1 for the patch. It shouldn't break compatibility, since converting chars to entities with different encoding does not work/make sense or I must be missing some. BTW, we're better to have PHPAPI function returns internal encoding, rather than switch(). -- Yasuo Ohgaki