Re: is this code decent?

From: Date: Tue, 21 Nov 2000 23:33:22 +0000
Subject: Re: is this code decent?
References: 1 2  Groups: php.general 
Request: Send a blank email to php-general+get-26542@lists.php.net to get a copy of this message
FYI http://www.php.net/switch for more info. --Joe On Tue, Nov 21, 2000 at 01:30:39PM -0800, jeremy brand wrote: > personally, I would use a couple of case statements, but if you syntax > is good, it should do what it says it is doing. > > -jeremy brand > > Jeremy Brand :: Sr. Software Engineer :: 408-245-9058 :: jeremy@nirvani.net > http://www.JeremyBrand.com/Jeremy/Brand/Jeremy_Brand.html for > more > - - - - - - - - - - - - - - - - - - - - - - - - - > I am pleased to see that we have differences. May we together become > greater than the sum of both of us. > -- Surak of Vulcan, "The Savage Curtain", stardate 5906.4 > > On Tue, 21 Nov 2000, Jerry Lake wrote: > > > Date: Tue, 21 Nov 2000 13:29:23 -0800 > > From: Jerry Lake <jerryl@europa.com> > > To: php-general@lists.php.net > > Subject: [PHP] is this code decent? > > > > I just want to get some opinions on whether or not > > my code looks decent (it works regardless) and if anyone has any advise > > on how to make it better, I'd appreciate it. > > > > <snip> > > <? > > // Begin Qwest Residential Pricing > > if ($servicespeed == 'Qwest 640k/272k' && $servicetype == > > 'Residential') { > > $cost = '19.95'; } > > elseif ($servicespeed == 'Qwest 640k/544k' && $servicetype == > > 'Residential') > > { > > $cost = '39.95'; } > > elseif ($servicespeed == 'Qwest 960k/816k' && $servicetype == > > 'Residential') > > { > > $cost = '59.95'; } > > elseif ($servicespeed == 'Qwest 1280k/1088k' && $servicetype == > > 'Residential') { > > $cost = '79.95'; } > > // Begin Qwest SOHO Pricing > > elseif ($servicespeed == 'Qwest 640k/272k' && $servicetype == > > 'SOHO') { > > $cost = '49.95'; } > > elseif ($servicespeed == 'Qwest 640k/544k' && $servicetype == > > 'SOHO') { > > $cost = '99.95'; } > > elseif ($servicespeed == 'Qwest 960k/816k' && $servicetype == > > 'SOHO') { > > $cost = '149.95'; } > > elseif ($servicespeed == 'Qwest 1280k/1088k' && $servicetype == > > 'SOHO') { > > $cost = '199.95'; } > > // Begin Qwest Business Pricing > > elseif ($servicespeed == 'Qwest 640k/272k' && $servicetype == > > 'Business') { > > $cost = '100.00'; } > > elseif ($servicespeed == 'Qwest 640k/544k' && $servicetype == > > 'Business') { > > $cost = '200.00'; } > > elseif ($servicespeed == 'Qwest 960k/816k' && $servicetype == > > 'Business') { > > $cost = '300.00'; } > > elseif ($servicespeed == 'Qwest 1280k/1088k' && $servicetype == > > 'Business') > > { > > $cost = '400.00'; } > > else { > > $cost = 'Call for Price'; } > > ?> > > </snip> > > > > Jerry Lake > > > > > > -- > > PHP General Mailing List (http://www.php.net/) > > To unsubscribe, e-mail: php-general-unsubscribe@lists.php.net > > For additional commands, e-mail: php-general-help@lists.php.net > > To contact the list administrators, e-mail: php-list-admin@lists.php.net > > > > > > > -- > PHP General Mailing List (http://www.php.net/) > To unsubscribe, e-mail: php-general-unsubscribe@lists.php.net > For additional commands, e-mail: php-general-help@lists.php.net > To contact the list administrators, e-mail: php-list-admin@lists.php.net ================================================================================ = Joe Stump joestump98@yahoo.com http://www.miester.org = ================================================================================ Need a programmer? http://www.google.com/search?q=joe+stump+resume

« previous php.general (#26542) next »