Re: is this code decent?
| From: | Mark Maggelet | Date: | Tue, 21 Nov 2000 21:53:43 +0000 |
| Subject: | Re: is this code decent? | ||
| References: | 1 | Groups: | php.general |
| Request: | Send a blank email to php-general+get-26530@lists.php.net to get a copy of this message | ||
something like this would be more readable:
$prices=array(
'Residential' => array(
'Qwest 640k/272k' => '19.95',
'Qwest 640k/544k' => '39.95',
'Qwest 960k/816k' => '59.95',
'Qwest 1280k/1088k' => '79.95'
),
'SOHO' => array(
// more...
),
'Business' => array(
// more...
)
);
$cost=$prices[$servicetype][$servicespeed];
- Mark
On Tue, 21 Nov 2000 13:29:23 -0800, Jerry Lake (jerryl@europa.com)
wrote:
>I just want to get some opinions on whether or not
>my code looks decent (it works regardless) and if anyone has any
>advise
>on how to make it better, I'd appreciate it.
>
><snip>
><?
>// Begin Qwest Residential Pricing
>if ($servicespeed == 'Qwest 640k/272k' && $servicetype ==
>'Residential') {
> $cost = '19.95'; }
>elseif ($servicespeed == 'Qwest 640k/544k' && $servicetype ==
>'Residential')
>{
> $cost = '39.95'; }
>elseif ($servicespeed == 'Qwest 960k/816k' && $servicetype ==
>'Residential')
>{
> $cost = '59.95'; }
>elseif ($servicespeed == 'Qwest 1280k/1088k' && $servicetype ==
>'Residential') {
> $cost = '79.95'; }
>// Begin Qwest SOHO Pricing
>elseif ($servicespeed == 'Qwest 640k/272k' && $servicetype ==
>'SOHO') {
> $cost = '49.95'; }
>elseif ($servicespeed == 'Qwest 640k/544k' && $servicetype ==
>'SOHO') {
> $cost = '99.95'; }
>elseif ($servicespeed == 'Qwest 960k/816k' && $servicetype ==
>'SOHO') {
> $cost = '149.95'; }
>elseif ($servicespeed == 'Qwest 1280k/1088k' && $servicetype ==
>'SOHO') {
> $cost = '199.95'; }
>// Begin Qwest Business Pricing
>elseif ($servicespeed == 'Qwest 640k/272k' && $servicetype ==
>'Business') {
> $cost = '100.00'; }
>elseif ($servicespeed == 'Qwest 640k/544k' && $servicetype ==
>'Business') {
> $cost = '200.00'; }
>elseif ($servicespeed == 'Qwest 960k/816k' && $servicetype ==
>'Business') {
> $cost = '300.00'; }
>elseif ($servicespeed == 'Qwest 1280k/1088k' && $servicetype ==
>'Business')
>{
> $cost = '400.00'; }
>else {
> $cost = 'Call for Price'; }
>?>
></snip>
>
>Jerry Lake
>
>
>--
>PHP General Mailing List (http://www.php.net/)
>To unsubscribe, e-mail: php-general-unsubscribe@lists.php.net
>For additional commands, e-mail: php-general-help@lists.php.net
>To contact the list administrators, e-mail: php-list-
>admin@lists.php.net