#37504 [Opn]: Patch for GtkTreeSortable::set_(default_)sort_func
| From: | andrei@php.net | Date: | Sun, 04 Jun 2006 18:04:08 +0000 |
| Subject: | #37504 [Opn]: Patch for GtkTreeSortable::set_(default_)sort_func | ||
| References: | 1 | Groups: | php.gtk.dev |
| Request: | Send a blank email to php-gtk-dev+get-2942@lists.php.net to get a copy of this message | ||
ID: 37504
Updated by: andrei@php.net
Reported By: cweiske@php.net
Status: Open
Bug Type: PHP-GTK related
Operating System: any
PHP Version: 5.1.4
New Comment:
Same things here as in another patch:
1. Put the declaration of marshaller into %headers section.
2. Assign value of retval to something before destroying it.
3. In GtkTreeModelFilter constructor, why use 'N' instead of 'V'? It's
the last parameter anyway, no need to allow user to pass NULL there.
Do you remember the problem we had with the set_visible() function? The
user data will not be freed and there will be a memory leak.
Previous Comments:
------------------------------------------------------------------------
[2006-05-18 18:31:44] cweiske@php.net
Forgot to mention that I had to modify gtk.defs to get the filter
constructor working.
http://xml.cweiske.de/patches/gtk.defs.diff
------------------------------------------------------------------------
[2006-05-18 18:30:52] cweiske@php.net
I added GtkTreeFilterModel constructor and set_visible_func (&
GtkTreeModelFilterVisibleFunc marshaller) to the patches.
------------------------------------------------------------------------
[2006-05-18 16:03:50] cweiske@php.net
Description:
------------
At
http://xml.cweiske.de/patches/gtktreeview.overrides.diff
is a patch that implements
GtkTreeSortable::set_sort_func
GtkTreeSortable::set_default_sort_func
and the marshaller.
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=37504&edit=1