#37504 [Opn->Csd]: Patch for GtkTreeSortable::set_(default_)sort_func

ID: 37504 Updated by: cweiske@php.net Reported By: cweiske@php.net -Status: Open +Status: Closed Bug Type: PHP-GTK related Operating System: any PHP Version: 5.1.4 New Comment: This bug has been fixed in CVS. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. Previous Comments: ------------------------------------------------------------------------ [2006-06-04 18:04:07] andrei@php.net Same things here as in another patch: 1. Put the declaration of marshaller into %headers section. 2. Assign value of retval to something before destroying it. 3. In GtkTreeModelFilter constructor, why use 'N' instead of 'V'? It's the last parameter anyway, no need to allow user to pass NULL there. Do you remember the problem we had with the set_visible() function? The user data will not be freed and there will be a memory leak. ------------------------------------------------------------------------ [2006-05-18 18:31:44] cweiske@php.net Forgot to mention that I had to modify gtk.defs to get the filter constructor working. http://xml.cweiske.de/patches/gtk.defs.diff ------------------------------------------------------------------------ [2006-05-18 18:30:52] cweiske@php.net I added GtkTreeFilterModel constructor and set_visible_func (& GtkTreeModelFilterVisibleFunc marshaller) to the patches. ------------------------------------------------------------------------ [2006-05-18 16:03:50] cweiske@php.net Description: ------------ At http://xml.cweiske.de/patches/gtktreeview.overrides.diff is a patch that implements GtkTreeSortable::set_sort_func GtkTreeSortable::set_default_sort_func and the marshaller. ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=37504&edit=1