Re: Window Build Patch - Check for grep and sed

grep/sed dependency was a temporary 'fix' a very long time ago. Sure, put these in for now, but they'll be reworked at some point because neither are native libs. ----- Original Message ----- From: "Elizabeth Smith" <emsmith@elizabethmariesmith.com> To: <php-gtk-dev@lists.php.net> Sent: Wednesday, February 28, 2007 1:26 AM Subject: [PHP-GTK-DEV] Window Build Patch - Check for grep and sed

I'm back to the grind again, after messing with php and pecl extensions for awhile. Currently we aren't checking for grep or sed in the windows configure script (which does bad things when you move them around on your system and they can't be found and then you try to compile php-gtk...let's just say "hang" is a kind description) This just adds a quick check that bails if they can't be found because allowing the generator batch file to run without them does naughty things. Can I get an ok to put this in Steph?

--------------------------------------------------------------------------------

Index: config.w32.in =================================================================== RCS file: /repository/php-gtk/win32/config.w32.in,v retrieving revision 1.12 diff -u -r1.12 config.w32.in --- config.w32.in 17 Jun 2006 14:47:08 -0000 1.12 +++ config.w32.in 28 Feb 2007 01:22:04 -0000 @@ -14,6 +14,12 @@ PATH_PROG('link', WshShell.Environment("Process").Item("PATH"), "LD"); PATH_PROG('nmake'); +// check for grep and sed! +if (!PATH_PROG('grep', WshShell.Environment("Process").Item("PATH")) ||

+    !PATH_PROG('sed', WshShell.Environment("Process").Item("PATH"))) {

+ ERROR("grep and sed are required"); +} + // we don't want to define LIB, as that will override the default library path set in that env var PATH_PROG('lib', null, 'MAKE_LIB'); PATH_PROG('php');

--------------------------------------------------------------------------------

-- PHP-GTK Development Mailing List (http://gtk.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php