Re: Re: Window Build Patch - Check for grep and sed

Elizabeth, anything that's non-intrusive (i.e. doesn't alter or impact existing code) you can just add into CVS, no problem. Sorry I didn't pick up 'til now that this was one such change. - Steph ----- Original Message ----- From: "Elizabeth Smith" <emsmith@elizabethmariesmith.com> To: <php-gtk-dev@lists.php.net> Sent: Wednesday, February 28, 2007 1:46 PM Subject: [PHP-GTK-DEV] Re: Window Build Patch - Check for grep and sed

Elizabeth Smith wrote:

Round three - add support for the GdkPixbuf::new_from_gd on windows Since the method will only work if gd is compiled statically into php, I made a new argument (--enable-gd) that simply sets the right compiler flag

I didn't get an answer yeah or nay on this one, probably because it got lost in the shuffle. We had talked about this earlier and decided a compile flag is the only nice way to support it, since the method doesn't work with shared gd (although if someone would fix that...) Since there's no way to query the php5(ts)(_debug).lib to see if it has gd support compiled in, the only way to really tell is using a configure flag. This just sets /D HAVE_GD_BUNDLED=1 so the new_from_gd is put into php-gtk2.dll Thanks ;)

--------------------------------------------------------------------------------

Index: config.w32.in =================================================================== RCS file: /repository/php-gtk/win32/config.w32.in,v retrieving revision 1.13 diff -u -r1.13 config.w32.in --- config.w32.in 28 Feb 2007 13:29:42 -0000 1.13 +++ config.w32.in 28 Feb 2007 13:30:32 -0000 @@ -51,6 +51,7 @@ ARG_WITH('php-build', 'Path to where you extracted http://www.php.net/extra/win32build.zip. Assumes that it is a sibling of this source dir (..\\php_build) if not specified', 'no'); ARG_WITH('cygwin', 'Path to cygwin utilities on your system', '\\cygwin'); +ARG_ENABLE('gd', 'Php has static gd', 'no'); // stick objects somewhere outside of the source tree ARG_ENABLE('object-out-dir', 'Alternative location for binary objects during build', ''); @@ -114,6 +115,10 @@ ADD_FLAG('CFLAGS', '/GS /wd4996 '); } +if (PHP_GTK_GD == "yes") { + ADD_FLAG('CFLAGS', '/D HAVE_GD_BUNDLED=1'); +} + if (PHP_GTK_PHP_BUILD == 'no') { if (FSO.FolderExists("..\\php_build")) { PHP_GTK_PHP_BUILD = "..\\php_build";

--------------------------------------------------------------------------------

-- PHP-GTK Development Mailing List (http://gtk.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php