Re: com php-src: ext/sodium: throw exceptions instead of errors: ext/sodium/libsodium.c
| From: | Remi Collet | Date: | Tue, 28 Nov 2017 16:30:03 +0000 |
| Subject: | Re: com php-src: ext/sodium: throw exceptions instead of errors: ext/sodium/libsodium.c | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-101184@lists.php.net to get a copy of this message | ||
Le 28/11/2017 à 15:27, Christian Schneider a écrit :
>>
>> I am very much in favor of this change. However, making such a change in
>> PHP 7.2.1 is a BC break. Any chance to get that into PHP 7.2.0?
>
> I'm wary of turning errors into exceptions because code which was returning a result with
> libsodium before (either PECL or PHP 7.2.0) - even though it was generating an E_WARNING/E_ERROR -
> now suddenly aborts with an exception.
I agree this change is quite bad...
> Would you still consider an exception a good idea if the minimum value for one of the function
> parameters is increased in a later version of libsodium?
I think a simple warning + value increased to a sane value should be
enough (could be done in PHP side, of course better if done in the library)
Remi.
Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc
Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc