Re: Re: com php-src: ext/sodium: throw exceptionsinstead of errors: ext/sodium/libsodium.c
| From: | Christoph M. Becker | Date: | Tue, 28 Nov 2017 23:17:28 +0000 |
| Subject: | Re: Re: com php-src: ext/sodium: throw exceptionsinstead of errors: ext/sodium/libsodium.c | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-101193@lists.php.net to get a copy of this message | ||
On 29.11.2017 at 00:03, Nikita Popov wrote:
> Previously: <Min: Generic SodiumException, <Interactive: Warning.> First commit:
> <Min: Specific E_ERROR, <Interactive: OK.> Second
commit: <Min: Specific SodiumException, <Interactive: OK.> Third commit:
<Min: Specific E_ERROR, <Interactive: OK.> > In summary, the first two
commits combined were not a BC break -- they only> removed a warning and
made an error message nicer. After the third commit> we now *do* have a
BC break, because what was previously a SodiumException> is now an
E_ERROR.> > I hope we can restore some sanity to this world by reverting
that revert...
+1
(thanks Nikita)
--
Christoph M. Becker