Re: Re: com php-src: ext/sodium: throw exceptions instead of errors: ext/sodium/libsodium.c

From: Date: Tue, 28 Nov 2017 23:11:21 +0000
Subject: Re: Re: com php-src: ext/sodium: throw exceptions instead of errors: ext/sodium/libsodium.c
References: 1 2 3 4  Groups: php.internals 
Request: Send a blank email to internals+get-101192@lists.php.net to get a copy of this message
2017-11-29 0:03 GMT+01:00 Nikita Popov <nikita.ppv@gmail.com>: > In summary, the first two commits combined were not a BC break -- they only > removed a warning and made an error message nicer. After the third commit > we now *do* have a BC break, because what was previously a SodiumException > is now an E_ERROR. > > I hope we can restore some sanity to this world by reverting that revert... All in all, E_ERROR should *never* be used by an extension, we should revert back to using an Exception and re-tag the 7.2.0 release asap -- regards, Kalle Sommer Nielsen kalle@php.net

« previous php.internals (#101192) next »