Re: [RFC] [VOTE] Deprecate PHP's short open tags, again
| From: | Arvids Godjuks | Date: | Thu, 08 Aug 2019 16:28:18 +0000 |
| Subject: | Re: [RFC] [VOTE] Deprecate PHP's short open tags, again | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-106447@lists.php.net to get a copy of this message | ||
чт, 8 авг. 2019 г. в 17:56, Robert Korulczyk <robert@korulczyk.pl>:
> > Many people have talked about the potential impacts of keeping short
> tags.
> > I have yet to see anyone give an actual example where they have been
> > negatively impacted by their existence. I've given you my personal story
> of
> > how removing them will negatively impact my company. I welcome anyone
> that
> > can provide an actual incident where the existence of short tags hurt
> them,
> > or, the continued existence is likely to have a large negative impact on
> > them in the future.
>
> I was bitten by short open tags. Despite the "no short open tag" policy in
> our app, one occurrence of
<? slipped through code review.
> It was in
> email template so it was quite hard to notice on production. Especially
> that short open tags were disabled only on CLI, so we had code leak only in
> emails sent by cron. It took over a month to notice that bug.
>
> You may be concerned about people abandoning PHP due to BC breaks, I'm
> more concerned about people abandoning PHP because of issues like this. It
> gives me the impression that the language wants to hurt you...
>
>
> Regards,
> Robert Korulczyk
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
I'd say this is not really a language concern and more tooling and testing
problem. It's a class of a genuine mistake everybody does from time to time
- be it wrong PHP tag, HTML tag or closing } added on the wrong line
resulting in a logical error.
--
Arvīds Godjuks
+371 26 851 664
arvids.godjuks@gmail.com
Skype: psihius
Telegram: @psihius https://t.me/psihius