Re: [RFC] Random Extension 3.0

On 9/2/21 5:10 PM, Go Kudo wrote:

Hi Internals. Expanded from the previous RFC and changed it to an RFC that organizes the whole PHP random number generator. Also, the target version has been changed to 8.2. https://wiki.php.net/rfc/rng_extension https://github.com/php/php-src/pull/7453 Hopefully you will get some good responses.

For me (user land developer with no voting power) your RFC looks pretty :) Beside the abstract vs interface question I have some other notes: On the one hand you define "getBytes()" which returns a string and on the other hand you define "shuffleString()" - is the first one a binary string and the other a charset dependent string? I guess here "shuffleString()" works on byte level and so it should be "shuffleBytes()". Why are there no default values for min/max on "getInt()" - It seems unnecessary to me to pass min/max arguments if you are just interested in a random integer or passing max as well if you are interested in a positive integer only. Thanks for the nice RFC!

Regards, Go Kudo Marc