Re: Adding `final class Deque` to PHP
| From: | tyson andre | Date: | Tue, 01 Feb 2022 13:47:45 +0000 |
| Subject: | Re: Adding `final class Deque` to PHP | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-116964@lists.php.net to get a copy of this message | ||
Hi Levi Morrison,
> I think this RFC is in much better shape now.
>
> The last thing I'll personally push for is dropping
get
> and set.
> I'm not sure about those names, and the functionality is already
> provided by offsetGet and offsetSet
>, albeit through mixed
> instead of int, but I think this sort of cleanup should be done
> en
> masse at some point, rather than having this one type doing something
> different from the others.
The get/set methods have been removed. I've updated the RFC and implementation.
Thanks,
Tyson